perf: eliminate more low-level allocations #1412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Still need to do the same forDockerUses.The idea here is to get rid of a few of the low-level allocations that happen over and over, namely in things like
Usesparsing. The main trick here is usingself_cellto hold onto the backingString(instead of destroying it throughfrom_str).We can actually go even further than this, since
serde_yamlsupports borrowing from the original input. But that'll be a bigger refactor, since we lose track of the original loaded input at the moment.