Skip to content

feat(meta): add disallowApplyAll options #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2022
Merged

feat(meta): add disallowApplyAll options #96

merged 1 commit into from
Jun 21, 2022

Conversation

NeverBehave
Copy link
Contributor

@NeverBehave NeverBehave commented Jun 18, 2022 •
edited
Loading

close #95

This PR also add metaConfig struct for hive.meta section.

otavio
otavio suggested changes Jun 18, 2022
View reviewed changes
zhaofengli
zhaofengli reviewed Jun 20, 2022
View reviewed changes
Copy link
Owner

@zhaofengli zhaofengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a changelog entry in manual/src/release-notes.md? Please squash the last two commits as well.

@NeverBehave NeverBehave requested a review from zhaofengli June 21, 2022 00:36
@NeverBehave @zhaofengli
feat(meta): add disallowApplyAll options
dd7a292 
unify meta access for machinesFile

update release note and config name
@zhaofengli
Copy link
Owner

Thanks!

@zhaofengli zhaofengli merged commit f35e6df into zhaofengli:main Jun 21, 2022
@zhaofengli zhaofengli mentioned this pull request Jun 21, 2022
Merged
@Radvendii Radvendii mentioned this pull request Jun 22, 2022
Closed
@NeverBehave NeverBehave deleted the feat/metaconfig branch July 28, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaofengli zhaofengli Awaiting requested review from zhaofengli

1 more reviewer

@otavio otavio otavio requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: prevent applying all

3 participants

@NeverBehave @zhaofengli @otavio