Skip to content

Conversation

@elza2
Copy link
Contributor

@elza2 elza2 commented Jan 10, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #20 (6cf9923) into master (4cd42de) will decrease coverage by 9.59%.
The diff coverage is 39.20%.

❗ Current head 6cf9923 differs from pull request most recent head e5a2837. Consider uploading reports for the commit e5a2837 to get more accurate results

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   69.08%   59.48%   -9.60%     
==========================================
  Files           6        7       +1     
  Lines         372      548     +176     
==========================================
+ Hits          257      326      +69     
- Misses        105      195      +90     
- Partials       10       27      +17     
Impacted Files Coverage Δ
middleware.go 20.23% <20.23%> (ø)
interceptor.go 53.19% <56.52%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lxy1992
lxy1992 previously approved these changes Jan 10, 2023
Copy link
Contributor

@lxy1992 lxy1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lxy1992 lxy1992 dismissed their stale review January 10, 2023 03:55

code coverage

Copy link
Contributor

@lxy1992 lxy1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请求给这两个文件加上UT,UT覆盖率掉了22%

@lxy1992 lxy1992 merged commit e6757f4 into zaihui:master Jan 10, 2023
li31727 pushed a commit that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants