Skip to content

Update MultiFormatReader example in README.md #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
werthdavid merged 1 commit into from
Apr 26, 2022
Merged

Update MultiFormatReader example in README.md #510

werthdavid merged 1 commit into from
Apr 26, 2022

Conversation

@inokawa
Copy link
Contributor

@inokawa inokawa commented Feb 28, 2022

If we call decode of MultiFormatReader without hints argument, this.hints seems overrided with undefined.

library/src/core/MultiFormatReader.ts

Lines 72 to 75 in 89c4c23

public decode(image: BinaryBitmap, hints?: Map<DecodeHintType, any>): Result {
this.setHints(hints);
return this.decodeInternal(image);
}

library/src/core/MultiFormatReader.ts

Lines 101 to 102 in 89c4c23

public setHints(hints?: Map<DecodeHintType, any> | null): void {
this.hints = hints;

@werthdavid werthdavid merged commit 4c35d16 into zxing-js:master Apr 26, 2022
@inokawa inokawa deleted the patch-1 branch April 26, 2022 05:48
@reinaldoalmeida reinaldoalmeida mentioned this pull request May 21, 2024
Open
@ali8889 ali8889 mentioned this pull request May 21, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this pull request May 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this pull request Jul 4, 2024
Open
@ali8889 ali8889 mentioned this pull request Jul 5, 2024
Open
@ali8889 ali8889 mentioned this pull request Jul 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this pull request Jul 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this pull request Sep 11, 2024
Open
@ali8889 ali8889 mentioned this pull request Sep 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werthdavid werthdavid werthdavid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inokawa @werthdavid