forked from minio/minio
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from minio:master #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
916
commits into
yixuqiu:master
Choose a base branch
from
minio:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62f0197 to
b6d4a77
Compare
3c6cebb to
2b0156b
Compare
Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.0...v4.5.1) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
These are needed checks for the functions to be un-crashable with any input given to `msgUnPath` (tested with fuzzing). Both conditions would result in a crash, which prevents that. Some additional upstream checks are needed. Fixes #20610
Remember GetMultiple() must be used if your target is calling PutMultiple(), without that the multiple events will not be replayed.
* Fix lint issues from v1.62.0 upgrade * Fix xlMetaV2TrimData version checks.
Since DeadlineConn would send deadline updates directly upstream, it would race with Read/Write operations. The stdlib will perform a read, but do an async SetReadDeadLine(unix(1)) to cancel the Read in `abortPendingRead`. In this case, the Read may override the deadline intended to cancel the read. Stop updating deadlines if a deadline in the past is seen and when Close is called. A mutex now protects all upstream deadline calls to avoid races. This should fix the short-term buildup of... ``` 365 @ 0x44112e 0x4756b9 0x475699 0x483525 0x732286 0x737407 0x73816b 0x479601 # 0x475698 sync.runtime_notifyListWait+0x138 runtime/sema.go:569 # 0x483524 sync.(*Cond).Wait+0x84 sync/cond.go:70 # 0x732285 net/http.(*connReader).abortPendingRead+0xa5 net/http/server.go:729 # 0x737406 net/http.(*response).finishRequest+0x86 net/http/server.go:1676 # 0x73816a net/http.(*conn).serve+0x62a net/http/server.go:2050 ``` AFAICT Only affects internode calls that create a connection (non-grid).
HTTP likes to slap an infinite read deadline on a connection and do a blocking read while the response is being written. This effectively means that a reading deadline becomes the request-response deadline. Instead of enforcing our timeout, we pass it through and keep "infinite deadline" is sticky on connections. However, we still "record" when reads are aborted, so we never overwrite that. The HTTP server should have `ReadTimeout` and `IdleTimeout` set for the deadline to be effective. Use --idle-timeout for incoming connections.
Manual heal can return XMinioHealInvalidClientToken if the manual healing is started in the first node, and the next mc call to get the heal status is landed on another node. The reason is that redirection based on the token ID is not able to redirect requests to the first node due to a typo. This also affects the batch cancel command if the batch is being done in the first node, the user will never be able to cancel it due to the same bug.
Previously, not setting http.Config.HTTPTimeout for logger webhook was resulting in a timeout of 0, and causing "deadline exceeded" errors in log webhook. This change introduces a new env variable for configuring log webhook timeout and more importantly sets it when the config is initialised.
Keep larger merge buffers When sending large messages >1K, the merge buffer would continuously be reallocated. This could happen on listings, where blocks are typically 4->8K. Keep merge buffer of up to 256KB. Benchmark with 4096b messages: ``` benchmark old ns/op new ns/op delta BenchmarkRequests/servers=2/bytes/par=32-32 8271 6360 -23.10% BenchmarkRequests/servers=2/bytes/par=64-32 7840 4731 -39.66% BenchmarkRequests/servers=2/bytes/par=128-32 7291 4740 -34.99% BenchmarkRequests/servers=2/bytes/par=256-32 7095 4580 -35.45% BenchmarkRequests/servers=2/bytes/par=512-32 6757 4584 -32.16% BenchmarkRequests/servers=2/bytes/par=1024-32 6429 4453 -30.74% benchmark old bytes new bytes delta BenchmarkRequests/servers=2/bytes/par=32-32 12090 821 -93.21% BenchmarkRequests/servers=2/bytes/par=64-32 17423 820 -95.29% BenchmarkRequests/servers=2/bytes/par=128-32 18493 822 -95.56% BenchmarkRequests/servers=2/bytes/par=256-32 18892 821 -95.65% BenchmarkRequests/servers=2/bytes/par=512-32 19064 826 -95.67% BenchmarkRequests/servers=2/bytes/par=1024-32 19038 842 -95.58% ```
Update github.com/cosnicolaou/pbzip2 to latest version for significant performance improvements. This update brings a 45% reduction in processing time.
The RemoveUser API only removes internal users, and it reports success when it didnt find the internal user account for deletion. When provided with a service account, it should not report success as that is misleading.
The experimental functions are now available in the standard library in Go 1.23 [1]. [1]: https://go.dev/doc/go1.23#new-unique-package Signed-off-by: Eng Zer Jun <[email protected]>
…I calls. Add retention settings to tags (#20638) * Add the policy name to the audit log tags when doing policy-based API calls * Audit log the retention settings requested in the API call * Audit log of retention on PutObjectRetention API path too
The code assigns corrupted state to a drive for any unexpected error, which is confusing for users. This change will make sure to assign corrupted state only for corrupted parts or xl.meta. Use unknown state with a explanation for any unexpected error, like canceled, deadline errors, drive timeout, ... Also make sure to return the bucket/object name when the object is not found or marked not found by the heal dangling code.
Signed-off-by: Benjamin Perez <[email protected]>
Golang http.Server will call SetReadDeadline overwriting the previous deadline configuration set after a new connection Accept in the custom listener code. Therefore, --idle-timeout was not correctly respected. Make http.Server read/write timeout similar to --idle-timeout.
Signed-off-by: Benjamin Perez <[email protected]>
Commit b6eb8df renamed compression setting environment variables to follow consistent style. Although it preserved backward compatibility for the most part (i.e. it handled MINIO_COMPRESS_ALLOW_ENCRYPTION, MINIO_COMPRESS_EXTENSIONS, and MINIO_COMPRESS_MIME_TYPES), MINIO_COMPRESS_ENABLE was left behind. Additionally, due to incorrect fallback ordering, and DefaultKVS containing enable=off allow_encryption=off (so kvs.Get should've been tried last), that commit broke MINIO_COMPRESS_ALLOW_ENCRYPTION (even though it appeared to be handled), and even older MINIO_COMPRESS, too. The legacy MIME types and extensions variables take precedence over both config and new variables, so they don't need fixing.
… access keys (#21549) fix: use correct dummy ARN for claim-based OIDC provider When listing OIDC access keys, use the correct ARN when looking up the provider configuration for the claim-based provider. Without this it was impossible to list access keys for a claim-based provider, only for a role-policy-based provider. Fixes #21548
Update tinylib. Should fix CI. `gofumpt -w .&&go generate ./...`
Added instructions for building Docker image and using Helm charts. This closes the loop on supported methods for deploying MinIO with latest changes.
Updated documentation link to point to the GitHub project.
This fixes a security issue where sub-policy attached to a service account or STS account is not properly validated under certain "own" account operations (like creating new service accounts). This allowed a service account to create new service accounts for the same user bypassing the inline policy restriction.
fix(api): Don't send responses twice. In some cases multiple responses are being sent for one request, causing the API server to incorrectly drop connections. This change introduces a ResponseWriter which tracks whether a response has already been sent. This is used to prevent a response being sent if something already has (e.g. by a preconditions check function). Fixes #21633. Co-authored-by: Menno Finlay-Smits <[email protected]>
…nce (#21638) Signed-off-by: yangw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )