[tree] Fix tree widget mouse handling #141
Conversation
Instead of only listening to `list.key()`, which ignores mouse-clicks, we use the `list`s own select event to re-propagate the `tree`s select event. This way the mouse-clicks also trigger the `select`. Since the existing `options.keys` are also passed to the `blessed.list()` and thus influence its `select` event, they should behave exactly the way they did til now.
|
@LinuCC we can continue working on this PR |
|
@lirantal is there anything I can do to get this fix merged? |
|
Wasn't aware that this is the finished version :-) |
|
Thank you for the resopnse! |
|
I don't want to block this off if you fixed it and believe you got it right. I'd be happy if you could quickly test it out with some edge cases and let's push it in. Ping me when you are ready :) |
|
Welp, I assumed passing all the keys to |
|
Thanks for looking into it more deeply. |
|
Will do once I have time! Won't take a year again, I promise ;) |
|
No worries, there's no rush. |
|
Any feedback. Best regards, |
|
Uh, right, testing this thing.
Well this aged like milk |
Instead of only listening to
list.key(), which ignores mouse-clicks,we use the
lists own select event to re-propagate thetrees selectevent.
This way the mouse-clicks also trigger the
select.Since the existing
options.keysare also passed to theblessed.list()and thus influence its
selectevent, they should behave exactly theway they did til now.