fix: allow case-insensitive DOCTYPE in HTML #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When introducing stricter parsing of the DOCTYPE and supporting more complex DTDs, we have not been aware that the HTML spec allows any kind of casing but only certain values. To make sure this change doesn't cause more harm, xmldom will still parse anything beside DTD syntax in HTML, and report warnings if there is anything unexpected in the systemId. (One example of this is parsing XHTML as HTML.) closes #817 https://html.spec.whatwg.org/multipage/syntax.html#the-doctype
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 95.08% 95.12% +0.04%
==========================================
Files 8 8
Lines 2177 2195 +18
Branches 571 577 +6
==========================================
+ Hits 2070 2088 +18
Misses 107 107 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing stricter parsing of the DOCTYPE and supporting more complex DTDs, we have not been aware that the HTML spec allows any kind of casing but only certain values.
To make sure this change doesn't cause more harm,
xmldom will still parse anything beside DTD syntax in HTML, and report warnings if there is anything unexpected in the systemId. (One example of this is parsing XHTML as HTML.)
closes #817
https://html.spec.whatwg.org/multipage/syntax.html#the-doctype