fix: getElements* methods return LiveNodeList<Element>
#734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NodeList and LiveNodeList are now generic, with a default of `Node` when no type argument is passed. - `Node.getElements*` and `Document.getElements*` return `LiveNodeList<Element>` - `NodeList[number]` is now typed as `T` instead of `T | undefined`, which of course only works for indexes < `length` Fixes #731
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 8 8
Lines 2094 2094
Branches 538 538
=======================================
Hits 1976 1976
Misses 118 118 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodewhen no type argument is passed.Node.getElements*andDocument.getElements*returnLiveNodeList<Element>NodeList[number]is now typed asTinstead ofT | undefined, which of course only works for indexes <lengthFixes #731