-
Notifications
You must be signed in to change notification settings - Fork 95
feat: add iterator function to NodeList and NamedNodeMap #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 93.89% 93.96% +0.06%
==========================================
Files 8 8
Lines 2048 2070 +22
Branches 532 536 +4
==========================================
+ Hits 1923 1945 +22
Misses 125 125 ☔ View full report in Codecov by Sentry. |
|
Can you please also add a test for these? |
|
There currently is a restriction to only use ES5 inside the lib folder. |
|
I added tests and rewrote the iterator to be ES5 compatible. As you can see it's way more code for the same thing but I guess it works... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when prefixing the unused item variables, that eslint complains about in the tests with _ eslint should stop complaining.
Great job!
|
@karfau done 😉 |
Closes #633