Channel api cleanup #3298
Merged
Channel api cleanup #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3298 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 87 87
Lines 28221 28221
=======================================
Hits 24898 24898
Misses 3323 3323 ☔ View full report in Codecov by Sentry. |
barrbrain
approved these changes
Dec 4, 2023
Collaborator
barrbrain
left a comment
There was a problem hiding this comment.
Looks good in principle. I guess we trade leaking types for coupling APIs.
Collaborator
Author
The patch adds our own error types, plugging the type-leak from crossbean, letting us pick whichever channel implementation since we controll the full interface to the user. Now you made me wonder about the From helpers. |
4863c0c to
21e91ad
Compare
21e91ad to
520d3a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.