Skip to content

Fix fall-through of x86 dispatch_predict_intra for CpuFeatureLevel::RUST #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barrbrain merged 1 commit into from
Jul 9, 2021
Merged

Fix fall-through of x86 dispatch_predict_intra for CpuFeatureLevel::RUST #2760

barrbrain merged 1 commit into from
Jul 9, 2021

Conversation

@barrbrain
Copy link
Collaborator

@barrbrain barrbrain commented Jul 9, 2021

Found by a failure of asm::shared::predict::test::pred_matches_u8 when running:

RAV1E_CPU_TARGET=rust cargo test --release --lib

tmatth
tmatth approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@tmatth tmatth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that thits fixes RAV1E_CPU_TARGET=rust locally.

@coveralls
Copy link
Collaborator

coveralls commented Jul 9, 2021

Coverage Status

Coverage decreased (-0.4%) to 83.505% when pulling 8c064f4 on barrbrain:x86-intra-rust-fall-through into f553646 on xiph:master.

@barrbrain barrbrain merged commit 8c064f4 into xiph:master Jul 9, 2021
@barrbrain barrbrain deleted the x86-intra-rust-fall-through branch July 9, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmatth tmatth tmatth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barrbrain @coveralls @tmatth