Skip to content

Conversation

nbradbury
Copy link
Contributor

This addresses the first part of #3779 by saving the short plan name with the blog object and displaying it on the My Site fragment.

cc @daniloercoli

@daniloercoli
Copy link
Contributor

I think you should include the parameter locale to the REST call to /me/sites. Otherwise you could see something like the following:

screen shot 2016-02-23 at 23 58 15

The Plan name in the screenshot above is not localized to IT.

@nbradbury
Copy link
Contributor Author

I think you should include the parameter locale to the REST call to /me/sites

I think you're right that we need to add the locale param, but I suspect we need to add that to a number of other calls as well. Do you think this should be addressed in this PR or as a separate issue?

@daniloercoli
Copy link
Contributor

I suspect we need to add that to a number of other calls as well. Do you think this should be addressed in this PR or as a separate issue?

You're right. I think, however, that's better to fix the issue in the /me/sites call in this PR, and open a new ticket for all other calls in the app.

Background: There are, unfortunately, different parts of the app that use string matching over the error string returned from the server to display a proper error to the user. This is due to some errors, returned from the server, that have the same error_code, but different error_description.
Ticket is here: #2789

…obile/WordPress-Android into issue/3779-store-plan-name-with-blog

Conflicts:
	WordPress/src/main/java/org/wordpress/android/ui/plans/PlansUtils.java
@nbradbury
Copy link
Contributor Author

@daniloercoli I added the locale param to me/sites in e9c59a8. Ready for another round!

@daniloercoli
Copy link
Contributor

:shipit:

daniloercoli added a commit that referenced this pull request Feb 25, 2016
…name-with-blog

Issue/3779 store plan name with blog
@daniloercoli daniloercoli merged commit 18dffec into feature/plans-master Feb 25, 2016
@daniloercoli daniloercoli deleted the issue/3779-store-plan-name-with-blog branch February 25, 2016 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants