CMM-801 create sync taxonomies calls in fluxC #22273
Merged
+160
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements local caching of taxonomy terms by integrating FluxC calls within the TermsViewModel to sync and store terms locally for quicker access. The implementation adds a new getLocalData() method to the DataView architecture to support showing locally cached data before network updates.
- Adds FluxC integration to store taxonomy terms locally when they are fetched from the network
- Updates the DataView architecture to support showing local data before network requests
- Modifies several ViewModels to properly initialize and leverage the local data functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TermsViewModel.kt | Core implementation adding FluxC integration and local data support for taxonomy terms |
| DataViewViewModel.kt | Base class updates to support displaying local data before network requests |
| ApplicationPasswordsViewModel.kt | Adds initialization call to enable local data functionality |
| SubscribersViewModel.kt | Adds initialization call to enable local data functionality |
| DataViewViewModelTest.kt | Test updates to ensure proper initialization during testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WordPress/src/main/java/org/wordpress/android/ui/taxonomies/TermsViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/taxonomies/TermsViewModel.kt
Show resolved
Hide resolved
Generated by 🚫 Danger |
|
| App Name | ||
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22273-8ee9e69 | |
| Commit | 8ee9e69 | |
| Direct Download | wordpress-prototype-build-pr22273-8ee9e69.apk |
|
| App Name | ||
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22273-8ee9e69 | |
| Commit | 8ee9e69 | |
| Direct Download | jetpack-prototype-build-pr22273-8ee9e69.apk |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22273 +/- ##
==========================================
- Coverage 39.88% 39.86% -0.02%
==========================================
Files 2168 2168
Lines 102823 102894 +71
Branches 14830 14840 +10
==========================================
+ Hits 41007 41015 +8
- Misses 58339 58399 +60
- Partials 3477 3480 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
dcalhoun
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is manually calling FluxC event every time the terms list is loaded. This helps to store the terms locally for quicker access.
Important note: Neither "Site settings" nor "DataView" support offline mode. So, even though the terms are stored locally, the flow when offline is not available.
Testing instructions