CMM-828 taxonomies data view second iteration create, update, delete support #22268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements CRUD (Create, Read, Update, Delete) functionality for the taxonomies data view feature in WordPress Android. It allows users to create new terms, edit existing terms, and delete terms through a comprehensive UI.
- Added create and update term functionality with form-based editing
- Implemented term deletion with confirmation dialogs
- Enhanced navigation system with dedicated screens for term creation and editing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| strings.xml | Added new string resources for term creation, deletion, and error messages |
| TermsViewModel.kt | Added CRUD operations, navigation logic, and state management for term editing |
| TermsDataViewActivity.kt | Implemented editable UI forms, navigation handling, and delete confirmation dialogs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WordPress/src/main/java/org/wordpress/android/ui/taxonomies/TermsViewModel.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/taxonomies/TermsViewModel.kt
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger |
|
| App Name | ||
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22268-d12bbac | |
| Commit | d12bbac | |
| Direct Download | jetpack-prototype-build-pr22268-d12bbac.apk |
|
| App Name | ||
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22268-d12bbac | |
| Commit | d12bbac | |
| Direct Download | wordpress-prototype-build-pr22268-d12bbac.apk |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22268 +/- ##
==========================================
- Coverage 39.89% 39.88% -0.01%
==========================================
Files 2168 2168
Lines 102699 102821 +122
Branches 14813 14830 +17
==========================================
+ Hits 40968 41007 +39
- Misses 58261 58337 +76
- Partials 3470 3477 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…teration--create,-update,-delete-support
|
2 tasks
dcalhoun
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
LGTM. The test plan succeeded for me. I did not encounter any issues.
I'll not some improvement opportunities we could consider in the future:
- Auto-capitalize the description fields, possibly the name fields as well.
- Add unique, descriptive a11y labels to all inputs making it clear which data field they control; currently, all are described in the same, generic "empty edit box" label.
- Add a11y announcement any time asynchronous work occurs, particularly the success/failure of adding/editing/deleting records.
- Consider grouping each label and input set into a single a11y item to reduce the number of "steps" in the forms.
- When persisting a record fails, display (and a11y announce) specific validation errors that prevented success.
- Evaluate whether we should use forward/back slides transitions rather than cross-fade transitions for navigating up/down these CRUD views.
- This may already be recognized, but, overall, the DataView UI feels unpolished; we should consider requesting a designer provide feedback at some point.
Thank you for your notes! I'll open a new issue to iterate over a11y stuff
I totally agree with that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes CMM-828 and CMM-829
This PR implements CRUD (Create, Read, Update, Delete) functionality for the taxonomies data view feature in WordPress Android. It allows users to create new terms, edit existing terms, and delete terms through the current Dataview.
Extra notes:
Testing instructions
Screen.Recording.2025-10-08.at.16.46.10.mov
NOTE: There's a UI glitch related to the top bar being displaced when opening the keyboard. But that glitch is also happening in
trunk. So I'm better isolating it in a different branch.