Skip to content

fix: Using showUi for taxonomies visibility #22266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

fix: Using showUi for taxonomies visibility #22266

merged 2 commits into from
Oct 9, 2025
+1 −1

Conversation

adalpari
Copy link
Contributor

@adalpari adalpari commented Oct 8, 2025 •
edited
Loading

Description

The PR updates the condition for displaying taxonomies in navigation menus by changing from checking showInNavMenus to showUi property for determining taxonomy visibility.

More info: #22255 (comment)

According to an internal conversation, show_in_menu is not available in the current API, so we are using show_ui

Testing instructions

Just check the code changes

@adalpari adalpari requested a review from Copilot October 8, 2025 10:00
Copilot
Copilot AI reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR updates the condition for displaying taxonomies in navigation menus by changing from checking showInNavMenus to showUi property for determining taxonomy visibility.

  • Changed the visibility check for taxonomies from showInNavMenus to showUi

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@adalpari adalpari marked this pull request as ready for review October 8, 2025 10:01
@adalpari adalpari requested a review from jkmassel October 8, 2025 10:01
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@adalpari adalpari enabled auto-merge (squash) October 8, 2025 10:02
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 8, 2025 •
edited
Loading

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr22266-427c2de
Commit427c2de
Direct Downloadwordpress-prototype-build-pr22266-427c2de.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 8, 2025 •
edited
Loading

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr22266-427c2de
Commit427c2de
Direct Downloadjetpack-prototype-build-pr22266-427c2de.apk
 Note: Google Login is not supported on these builds.

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 39.88%. Comparing base (9ff1f8a) to head (427c2de).
⚠️ Report is 3 commits behind head on trunk.

Files with missing lines Patch % Lines
.../ui/prefs/taxonomies/TaxonomiesNavMenuViewModel.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #22266   +/-   ##
=======================================
  Coverage   39.88%   39.88%           
=======================================
  Files        2168     2168           
  Lines      102823   102823           
  Branches    14830    14830           
=======================================
  Hits        41007    41007           
  Misses      58339    58339           
  Partials     3477     3477

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adalpari adalpari merged commit 29dbe55 into trunk Oct 9, 2025
23 checks passed
@adalpari adalpari deleted the fix/user-proper-visibuility-for-taxonomies branch October 9, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jkmassel jkmassel jkmassel approved these changes

Assignees
No one assigned
Labels
[Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adalpari @dangermattic @wpmobilebot @jkmassel