Fixes: crash on site creation in jetpack #18740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#18726
This PR fixes a crash in Jetpack app on site creation activity. THis PR was introduced due to the change in the PR #18597 where the Jetpack overlay fragment was created/retrieved on orientation change. Since on Jetpack App, the jetpack feature overlay is not shown, the overlay events should not be subscribed.
test
Verify no crashes - JP app
Regression testing - WP app
verify that there is no crash
verify that there is no crash and close button on horizontal direction works
Regression Notes
Potential unintended areas of impact
WP app site creation overlay is not shown
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: