Skip to content

Conversation

AjeshRPai
Copy link
Contributor

Fixes

#18726

This PR fixes a crash in Jetpack app on site creation activity. THis PR was introduced due to the change in the PR #18597 where the Jetpack overlay fragment was created/retrieved on orientation change. Since on Jetpack App, the jetpack feature overlay is not shown, the overlay events should not be subscribed.

test

Verify no crashes - JP app

  1. Login to the Jetpack app
  2. tap add a new site button → create wordpress.com site
  3. when the jetpack overlay opens, change the orientation to the portrait/landscapre.
  4. tap the x button.
  5. verify that there are no crashes.

Regression testing - WP app

verify that there is no crash

  1. launch wp app in the horizontal orientation.
  2. sign up.
  3. tap add a new site button → create wordpress.com site
  4. when the jetpack overlay opens, change the orientation to the portrait.
  5. tap the x button.
  6. verify that there are no crashes.

verify that there is no crash and close button on horizontal direction works

  1. launch wp app in the horizontal orientation.
  2. sign up.
  3. tap add a new site button → create wordpress.com site
  4. tap the x button.
  5. verify that there are no crashes and the previous screen is shown as intended

Regression Notes

  1. Potential unintended areas of impact
    WP app site creation overlay is not shown

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18740-5250962
Commit5250962
Direct Downloadwordpress-prototype-build-pr18740-5250962.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18740-5250962
Commit5250962
Direct Downloadjetpack-prototype-build-pr18740-5250962.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All cases are tested and passed. 🟢
Thanks for taking care of this. LGTM! 👍🏻

@irfano irfano self-assigned this Jul 5, 2023
@irfano irfano merged commit 29c1b03 into release/22.7 Jul 5, 2023
@irfano irfano deleted the 18726-runtimeexception-unable-to-start-activity-componentinfocomjetpackandroidorgwordpressandroiduisitecreation branch July 5, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants