Skip to content

Issue/17260 wordpress module asynctask warning commentdetailactivity #18480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Issue/17260 wordpress module asynctask warning commentdetailactivity #18480

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa632a2
issue-17260: initial commit changes CommentsDetailsActivity Java->Kotlin
May 21, 2023
ef0fad1
Rename .java to .kt
May 21, 2023
9d132d4
issue-17260:resolve code conversion errors & unused imports
May 21, 2023
07545be
issue-17260: code formatting
May 21, 2023
ea34e7b
issue-17260: adding deprecates suppression
May 21, 2023
35fbda7
issue-17260: resolving (non-null !!) warnings & fixing detekt errors
May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
issue-17260: adding deprecates suppression
  • Loading branch information
shifli7 committed May 21, 2023
commit ea34e7b03f4699319509aaf581d308bc5b9299ba
11 changes: 9 additions & 2 deletions WordPress/src/main/java/org/wordpress/android/ui/comments/CommentsDetailActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@file:Suppress("DEPRECATION")

package org.wordpress.android.ui.comments

import org.wordpress.android.util.extensions.onBackPressedCompat
Expand Down Expand Up @@ -53,15 +55,17 @@ import org.wordpress.android.util.ToastUtils
class CommentsDetailActivity : LocaleAwareActivity(), OnLoadMoreListener, OnCommentActionListener,
ScrollableViewInitializedListener {

@JvmField
@Inject
@Suppress("DEPRECATION")
@JvmField @Inject
var mCommentsStoreAdapter: CommentsStoreAdapter? = null
private lateinit var mViewPager: WPViewPager
private var mAppBarLayout: AppBarLayout? = null
private var mProgressBar: ProgressBar? = null
private var mCommentId: Long = 0
private var mStatusFilter: CommentStatus? = null
private var mSite: SiteModel? = null

@Suppress("DEPRECATION")
private var mAdapter: CommentDetailFragmentAdapter? = null
private var mOnPageChangeListener: OnPageChangeListener? = null
private var mIsLoadingComments = false
Expand All @@ -73,6 +77,7 @@ class CommentsDetailActivity : LocaleAwareActivity(), OnLoadMoreListener, OnComm
const val COMMENT_STATUS_FILTER_EXTRA = "commentStatusFilter"
}

@Suppress("DEPRECATION")
public override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
mCommentsStoreAdapter!!.register(this)
Expand Down Expand Up @@ -203,6 +208,7 @@ class CommentsDetailActivity : LocaleAwareActivity(), OnLoadMoreListener, OnComm
}
}

@Suppress("DEPRECATION")
private fun loadDataInViewPager() {
if (mIsLoadingComments) {
AppLog.w(AppLog.T.COMMENTS, "load comments task already active")
Expand All @@ -222,6 +228,7 @@ class CommentsDetailActivity : LocaleAwareActivity(), OnLoadMoreListener, OnComm
}
}

@Suppress("DEPRECATION")
private fun showCommentList(commentList: CommentList) {
if (isFinishing) {
return
Expand Down