Skip to content

Conversation

Hoossayn
Copy link
Contributor

@Hoossayn Hoossayn commented Nov 9, 2022

Parent: #17010

This PR resolves/suppresses all complexity related LongMethod warnings for the HomePageSettingsDialog class, AuthorUseCase class, ClicksUseCase class, and ReferrersUseCase class (see docs here):

4 x LongMethod (Resolve: ad6bb23 + 1cbf132 + f887ee0 + 4e0cee3 + ccbb810 + 0431cde + 55311df + 9432e48 )


To test:

  • There is nothing much to test here.

  • Verifying that all the CI checks are successful should be enough (especially the detekt check).

  • However, if you really want to be thorough, you could smoke test the WordPress and/or Jetpack apps to verify that everything works as expected on every screen that relates to these changes. Specifically, you could follow the below steps:

    • Go to the menu tab
    • Click on site settings
    • Select HomePage settings
    • Test that you can change between different homepage settings

To Test Stats

  • Go to the menu tab
  • Click on Stat
  • Click on Days tab and confirm that the correct data for Referrers, Clicks, and Authors are displaying
  • Do same for weeks, months and year tab

Regression Notes

  1. Potential unintended areas of impact
    can't think of any

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    See To test section above.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Hoossayn Hoossayn marked this pull request as ready for review November 10, 2022 09:43
@Hoossayn
Copy link
Contributor Author

👋🏾 @ParaskP7