-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Detekt - Resolve/Suppress All Baseline Warnings - Long methods warnings_ HomePageSettingsDialog, AuthorUseCase, ClicksUseCase, ReferrersUseCase #17446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Hoossayn
wants to merge
18
commits into
wordpress-mobile:trunk
from
Hoossayn:issue/17010-home-page-settings-dialog-detekt-baseline-warnings
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HomepageSettingsDialog from baseline.xml
👋🏾 @ParaskP7 |
Parent: #17010
This PR resolves/suppresses all complexity related LongMethod warnings for the HomePageSettingsDialog class, AuthorUseCase class, ClicksUseCase class, and ReferrersUseCase class (see docs here):
4
x LongMethod (Resolve: ad6bb23 + 1cbf132 + f887ee0 + 4e0cee3 + ccbb810 + 0431cde + 55311df + 9432e48 )To test:
There is nothing much to test here.
Verifying that all the CI checks are successful should be enough (especially the detekt check).
However, if you really want to be thorough, you could smoke test the WordPress and/or Jetpack apps to verify that everything works as expected on every screen that relates to these changes. Specifically, you could follow the below steps:
To Test
Stats
Days
tab and confirm that the correct data forReferrers
,Clicks
, andAuthors
are displayingweeks
,months
andyear
tabRegression Notes
Potential unintended areas of impact
can't think of any
What I did to test those areas of impact (or what existing automated tests I relied on)
See
To test
section above.What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.