Skip to content

No network check for saving tags #16737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

No network check for saving tags #16737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix : network connectivity now checked before the tag is saved
  • Loading branch information
Carl Duncan committed Jun 17, 2022
commit 6972fd5f7e144aa7773cdc317831ddd3d6bbe7e7
4 changes: 4 additions & 0 deletions WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsTagListActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ public void onBackPressed() {
if (getFragmentManager().getBackStackEntryCount() > 0) {
SiteSettingsTagDetailFragment fragment = getDetailFragment();
if (fragment != null && fragment.hasChanges()) {
if (!NetworkUtils.checkConnection(getBaseContext())) {
hideDetailFragment();
return;
}
saveTag(fragment.getTerm(), fragment.isNewTerm());
} else {
hideDetailFragment();
Expand Down