Quick Start for Existing Users V2: Hide quick start for self-hosted sites #16576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
23 tasks
|
You can test the changes on this Pull Request by downloading the APKs: |
|
This fix has now been shipped as part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent #16347
This PR hides the
Quick Startfor self-hosted sites not usingwpcomrest API. While theQuick Startcard was not shown for self-hosted sites after login, it appeared on refreshing the screen.Related iOS issue: wordpress-mobile/WordPress-iOS#18547
self-hosted-site-qs.mp4
To test
Quick Startcard is not displayed on theMy Sitescreen.Quick Startcard is not displayed on theMy Sitescreen.Merge Instructions
Targets code-frozen
release/19.9branch./cc @AliSoftware
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
See
To Testsection.What automated tests I added (or what prevented me from doing so)
Added unit tests for
QuickStartCardSourceto return non-empty quick start categories (needed for building the card ) only if quick start is available for the selected site.PR submission checklist:
RELEASE-NOTES.txtif necessary.