Skip to content

Quick Start for Existing Users V2 - Jetpack app - Replace app name in "Get to know the app" quick start card #16544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

Quick Start for Existing Users V2 - Jetpack app - Replace app name in "Get to know the app" quick start card #16544

merged 1 commit into from
May 16, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 13, 2022

Parent #16347

This PR replaces the app name for the Jetpack app in "Get to know the app" quick start card.

Quick Start Card Quick Start Tasks List
Screenshot_20220513_180019 Screenshot_20220513_180100

To test:

  1. Install Jetpack app.
  2. Launch the app.
  3. Enable to Me -> App Settings -> Debug settings -> QuickStartForExistingUsersV2FeatureConfig.
  4. Restart the app.
  5. Logout/login and select "Show me around" when the quick start prompt is shown.
  6. Select an existing site.
  7. Go to My Site tab.
  8. ✅ Notice that the new Quick Start card is shown with Get to know the Jetpack app title.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 19.9 milestone May 13, 2022
@ashiagr ashiagr requested a review from AjeshRPai May 13, 2022 12:34
@ashiagr ashiagr self-assigned this May 13, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ashiagr ashiagr mentioned this pull request May 13, 2022
Open
23 tasks
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

AjeshRPai
AjeshRPai approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the code changes and tested it as per the instructions. Everything looks good to me. Great Job @ashiagr. 👍 🙌

@AjeshRPai AjeshRPai merged commit 39fc998 into trunk May 16, 2022
@AjeshRPai AjeshRPai deleted the issue/qseuv2-jp-app-replace-app-name-for-get-to-know-app-card branch May 16, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AjeshRPai AjeshRPai AjeshRPai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashiagr ashiagr

Labels

Quick Start

Projects

None yet

Milestone

19.9

Development

Successfully merging this pull request may close these issues.

2 participants

@ashiagr @AjeshRPai