Adds: Skeleton classes for Category Detail Screen #16066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
7 tasks
ashiagr
approved these changes
Mar 9, 2022
| viewModel.start(site) | ||
| } | ||
|
|
||
| private fun getSite(savedInstanceState: Bundle?): SiteModel { |
There was a problem hiding this comment.
I think we can utilize SelectedSiteRepository in the VM to get the currently selected site. Feel free to ignore it for now and try it in your implementation PR.
There was a problem hiding this comment.
@ashiagr Let's ignore it for now, I hadn't looked at the SelectedSiteRepository for getting the site model. Thanks for letting me know. I will make that change in the implementation PR.
|
@ashiagr Thanks for reviewing the PR and giving me suggestions. 🙌 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent #16058
To test:
As these are only skeleton classes that are not being called in the UI these cannot be tested from the app.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.