WP Stories : Remote image thumbnail issue #12286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/portkey-android/issue/375 - Port Key PR
NOTE: BUILDS ON TOP OF #12297
Findings
When remote images are being loaded from Pexels, the thumbnail
ImageView
is not being set with the downloaded drawable.To rectify this issue, here are a few approaches that were tried :
Glide
object to see if there would be any log output but there was none.GlobalLayoutListener
to only apply the image when we are sure theImageView
was loaded but that didn't solve the problem either.Solution
The solution I ended up going with was to delay the setting loading of the image by 1 second so any other operation that's causing the discrepancy would have enough time to be completed so the image loading operation is able to be completed successfully.
Testing
Reviewing
Only 1 reviewer is needed but anyone can review.
Submitter Checklist
RELEASE-NOTES.txt
if necessary.