WP Stories integration: add EmojiCompat library for stories emoji support #12045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
This was referenced May 29, 2020
3 tasks
…p-stories-part9-emoji-compat
jd-alexander
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Thanks for these changes @mzorz works well! LGTM 🚢
The only thing I noticed here was when I opened the emoji drawer, the background was white but I think that is unrelated to these changes. Here it is below.
5 tasks
ParaskP7
added a commit
that referenced
this pull request
Jan 26, 2023
Since this project is now on 'Appcompat' version '1.4.2', there is no need for custom emoji support anymore. Using 'Appcompat' version '1.4.0' and above automatically adds support for latest emoji. For more info see: - Use AppCompat to support the latest emoji (Doc): https://developer.android.com/develop/ui/views/text-and-emoji/ emoji2#appcompat This change effectively reverts this PR below: #12045 For more specific on this change see GitHub discussion below: https://github.com/wordpress-mobile/WordPress-Android/issues/ 17565#issuecomment-1403805689
ParaskP7
added a commit
that referenced
this pull request
Jan 26, 2023
Since this project is now on 'Appcompat' version '1.4.2', there is no need for custom emoji support anymore. Using 'Appcompat' version '1.4.0' and above automatically adds support for latest emoji. For more info see: - Use AppCompat to support the latest emoji (Doc): https://developer.android.com/develop/ui/views/text-and-emoji/ emoji2#appcompat This change effectively reverts this PR below: #12045 For more specifics on this change see GitHub discussion below: https://github.com/wordpress-mobile/WordPress-Android/issues/ 17565#issuecomment-1403805689
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #12031
This PR implements the EmojiCompat library for support of emoji in the Stories library.
What / Why / How
This PR implements
EmojiCompatso to be able to have emojis on devices that may not have support for them on their installed Fonts.This PR uses the latest
EmojiCompatlibrary which is supposed to encapsulate the problems we'd otherwise need to tackle separately (downloading the fonts, then using them).Resources:
androidxpackage now, but the core mechanism still is the same) https://developer.android.com/guide/topics/ui/look-and-feel/emoji-compat#using-widgets-with-appcompatBasically followed the sample app https://github.com/googlesamples/android-EmojiCompat and implemented the core parts here.
On downloadable fonts
For more information on how downloadable fonts work, read here and here (see the part titled "Download fonts as XML resources") and then this article by Google's font engineering lead
(tl;dr: it can all be done through XML for the platform to perform automatically on first app run, and Android Studio sets up everything for you, as done with the EmojiCompat library in particular).
Notes:
FontRequestare borrowed from Google's EmojiCompat sample app, I haven't found anywhere in the docs that these should (or should not) be the ones to be used, but judging from the package names it looks like these certs should correspond to Google's, as this is how the call looks like:
Also, if you add a reference to EmojiCompat these are indeed the same ones that Android Studio adds to your project. - the requested Font is as per the sample app `Noto Color Emoji Compat`, the information on which can be found here: https://www.google.com/get/noto/help/emoji/To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.