Skip to content

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Aug 30, 2019

Fixes #10427

To test:

Testing on release build version

  1. Sign Up For WordPress.
  2. Once you have reached the New Account screen, ensure you have a short Display Name of three letters or less.
  3. click the username control.
  4. The error should then appear with a query instead of null.

Testing using the debug app.

  1. Utilize the testing steps to modify code from this PR so that you are able to reach the new account screen from the login page since during development the app can't access signup functionality.
  2. Follow steps 2 to 4 from above.

Below is an example where I used a single letter j as my display name and it's shown instead of null

Webp net-resizeimage (2)

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 30, 2019

Warnings
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS

@maxme maxme self-requested a review September 6, 2019 15:01
@maxme maxme self-assigned this Sep 6, 2019
@maxme maxme added this to the 13.3 milestone Sep 6, 2019
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@maxme maxme merged commit b814a5a into wordpress-mobile:develop Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Null username is shown on signup username suggestions screen

2 participants