Support for the EditorDidMount callback from GB #9230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniloercoli
approved these changes
Feb 13, 2019
|
Updated the gutenberg-mobile ref to the merged commit and will merge now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the wpandroid side PR to support wordpress-mobile/gutenberg-mobile#587
It adds support for the "boot" callback the editor is calling to inform that mounting has happened. It also passes a flag to denote if any unsupported blocks have been detected. We'll use that in a follow up PR to add Tracks.
Note: we will update the submodule hash when the gutenberg-mobile PR gets merged.
To test:
Additional test:
2. Add a toast in the
onEditorDidMountoverride in theGutenbergEditorFragmentfragment to see the callback be called.Update release notes:
RELEASE-NOTES.txt.