Skip to content

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jan 8, 2019

Fixes #8659

The offset parameter of the /read/feed/ API call needs to point beyond the previous results so, it has to be greater than the (zero-based) index of the last item. For example, if we're querying for 10 items, the first page will be from 0 index to index 9 so, the offset needs to be 10 to point to the start of the next page.

To test:

  1. Go to the Reader
  2. Have "Followed Sites" as the selected Reader section
  3. Tap on the search on the right (the magnifier glass icon)
  4. Type a query, for example: test
  5. Select the "Sites" tab from the results
  6. Scroll to the end of the list to trigger infinite scroll. Notice the last item while the new search is ongoing.
  7. Scroll a couple of items down and notice that the last item of the first "page" is not repeated

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added the Reader label Jan 8, 2019
@hypest hypest added this to the 11.6 milestone Jan 8, 2019
@hypest hypest requested a review from daniloercoli January 8, 2019 10:02
@daniloercoli
Copy link
Contributor

Looks good! :shipit:

@hypest hypest self-assigned this Jan 8, 2019
@hypest hypest merged commit 0dee201 into develop Jan 8, 2019
@hypest hypest deleted the issue/8659-same-stable-id-viewholders branch January 8, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants