Remove aztec Toolbar from Gutenberg editor fragment #8716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
reviewed
Dec 3, 2018
| android:layout_width="match_parent"> | ||
|
|
||
| <org.wordpress.aztec.toolbar.AztecToolbar | ||
| android:id="@+id/formatting_toolbar" |
There was a problem hiding this comment.
It seems we can remove the layout_above from the LinearLayout below too. While at it, it seems that the root RelativeLayout has no other children than the LinearLayout itself so, wdyt about removing one or the other?
There was a problem hiding this comment.
That's right! removed the now unneeded wrapping RelativeLayout in afcf44a
hypest
reviewed
Dec 3, 2018
|
|
||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:aztec="http://schemas.android.com/apk/res-auto" |
There was a problem hiding this comment.
Nit: let's remove the now unused namespace declaration, wdyt?
There was a problem hiding this comment.
👍 addressed in d16d1e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
AztecToolbarfromGutenbergEditorFragment.