Skip to content

Use example values that make Helpshift happy #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2018
Merged

Use example values that make Helpshift happy #7289

merged 1 commit into from
Feb 23, 2018

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 23, 2018 •
edited
Loading

Fixes #7282

Update the example Helpshift keys to avoid having Helpshift crash the app at launch.

To test:

  1. Follow the Build Instructions
  2. Build the app (wasabiDebug) and run it

@maxme maxme self-assigned this Feb 23, 2018
@maxme
Copy link
Contributor

maxme commented Feb 23, 2018

:shipit: app builds and runs well without any changes to the default values.

@maxme maxme merged commit a29ceec into develop Feb 23, 2018
@maxme maxme deleted the issue/7282-crash-with-example-helpshift-keys branch February 23, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@maxme maxme

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hypest @maxme