Async promo dialog #6467
Merged
Async promo dialog #6467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzorz
reviewed
Aug 3, 2017
| import org.wordpress.android.ui.accounts.login.Login2FaFragment; | ||
| import org.wordpress.android.ui.accounts.login.LoginEmailFragment; | ||
| import org.wordpress.android.ui.accounts.login.LoginEmailPasswordFragment; | ||
| import org.wordpress.android.ui.accounts.login.LoginEpilogueFragment; |
mzorz
reviewed
Aug 3, 2017
| void inject(ReaderPostPagerActivity object); | ||
|
|
||
| void inject(EditorReleaseNotesActivity object); | ||
| void inject(ReleaseNotesActivity object); |
mzorz
reviewed
Aug 3, 2017
| resizePhotoPicker(); | ||
| } | ||
|
|
||
| // If we're showing the Async promo dialog, we need to redraw it so it takes into account |
There was a problem hiding this comment.
not sure what the comment meant, it should continue but ends abruptly?
There was a problem hiding this comment.
Woops! Fixed in 0a81c29.
mzorz
reviewed
Aug 3, 2017
| */ | ||
| public class PromoDialogAdvanced extends PromoDialog { | ||
| public static class Builder extends PromoDialog.Builder { | ||
| @StringRes int linkId; |
There was a problem hiding this comment.
can we make these linkResId, buttonNegativeResId, descriptionResId etc?
There was a problem hiding this comment.
Done in f4e7063.
Adds a promo dialog, shown the first time a user presses the 'Publish' button:
Note: For now, the 'How does it work?' text is hidden. Closer (or just after) the beta we'll put up a post on mobile make, link to that, and unhide the link text.
I also added a new
PromoDialogAdvanced, intended for reuse for any dialogs requiring a link or negative button field (the existingPromoDialogEditornow extends this one, adding an extra title field for 'Beta'). The pre-existingPromoDialogcan be used for simple (image, title, description, positive button) promos.Also some design changes:
cc @iamthomasbishop (no visual changes to the async promo since we last spoke)