Deps: Remove patched and pinned @wordpress/[email protected]
#62499
+210
−672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Testing GuidelinesHi @jorgeatorres @sunyatasattva @Aljullu @gigitux @dinhtungdu @kmanijak , Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. Reminder: PR reviewers are required to document testing performed. This includes:
|
…mmerce, woocommerce/client/admin
Contributor
📝 WalkthroughWalkthroughRemoves a patched version of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧠 Learnings (14)📓 Common learnings📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-11-24T16:12:58.709ZApplied to files:
📚 Learning: 2025-08-22T10:00:26.594ZApplied to files:
📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-08-19T10:43:00.733ZApplied to files:
📚 Learning: 2025-12-11T15:57:36.702ZApplied to files:
📚 Learning: 2025-08-19T10:42:44.153ZApplied to files:
📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-11-10T09:50:13.291ZApplied to files:
📚 Learning: 2025-07-15T15:39:21.856ZApplied to files:
📚 Learning: 2025-11-24T16:12:58.709ZApplied to files:
📚 Learning: 2025-08-07T10:34:27.723ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (286)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📝 WalkthroughWalkthroughThis change removes a patch previously applied to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧠 Learnings (16)📓 Common learnings📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-11-24T16:12:58.709ZApplied to files:
📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-08-22T10:00:26.594ZApplied to files:
📚 Learning: 2025-06-20T17:38:16.565ZApplied to files:
📚 Learning: 2025-12-11T15:57:36.702ZApplied to files:
📚 Learning: 2025-11-24T16:13:34.861ZApplied to files:
📚 Learning: 2025-11-24T16:12:58.709ZApplied to files:
📚 Learning: 2025-08-19T10:43:00.733ZApplied to files:
📚 Learning: 2025-08-19T10:42:44.153ZApplied to files:
📚 Learning: 2025-07-15T15:39:21.856ZApplied to files:
📚 Learning: 2025-08-07T10:34:27.723ZApplied to files:
📚 Learning: 2025-11-24T16:12:58.709ZApplied to files:
📚 Learning: 2025-12-11T15:57:36.702ZApplied to files:
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Size Change: -70 B (0%) Total Size: 5.94 MB
|
Contributor
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
kmanijak
reviewed
Dec 17, 2025
Contributor
kmanijak
left a comment
There was a problem hiding this comment.
I don't think we can do it just yet. The reason I didn't remove it is because Launch Your Store relies on @wordpress/edit-site/build-module/components/* imports and there's at least one journey impacted by bumping the version.
Try:
- Reset Launch Your Store journey if needed by Tools > WCA Test Helper > Tools > Reset Launch Your Store
- Go to Onboarding > Launch Your Store
- Open browsers dev console
- Click "Collect sales tax"
On trunk there's no error while on this branch there's an error:
Uncaught TypeError: navigate is not a function
at handleClick (index.js:44:1)
at Object.kj (react-dom.min.js?ver=18:223:217)
at jj (react-dom.min.js?ver=18:34:117)
at mj (react-dom.min.js?ver=18:34:171)
at gh (react-dom.min.js?ver=18:62:93)
at Xg (react-dom.min.js?ver=18:63:1)
at react-dom.min.js?ver=18:72:332
at Tf (react-dom.min.js?ver=18:189:448)
at wg (react-dom.min.js?ver=18:32:481)
at Ce (react-dom.min.js?ver=18:65:218)
pointing at @wordpress/edit-site internals.
This requires deeper look but I'd wary from removing this until we maybe revisit LYS flow and make sure we don't depend on built module (which obviously could've changed since). I didn't test fully LYS so there may be other gaps.
What we can do is try to remove patch itself but I don't think we can remove anchored version for now.
Contributor
|
But also a side comment: I'd consider removing or simplifying LYS flow similar to what we did with CYS. I personally consider extremely complex code-wise while compared to what functionality it actually offers. WDYT @tyxla , @sunyatasattva? I have a feeling we could simplify it drastically and also get rid of tech debt for example by stopping relying on anchored WordPress dependency, etc. |
Member
I'm second to these. I'm a developer commenting on UX here, but the moment you click on 'Collect sales tax' or 'Select shipping options,' you're redirected to another screen with a different design, and I feel disconnected in the user flow, tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
After CYS was removed in #61932, the patched
@wordpress/edit-sitedependency is no longer needed.This PR removes it.
Closes #52670.
Fixes #WOOPLUG-2723.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Testing that has already taken place:
Smoke testing of the admin.
Milestone
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment
Deps: Remove patched and pinned @wordpress/[email protected]