Skip to content

Remove the request to the feature-freeze webhook #62471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
albarin wants to merge 2 commits into from
Closed

Remove the request to the feature-freeze webhook #62471

albarin wants to merge 2 commits into from

Conversation

@albarin
Copy link
Contributor

@albarin albarin commented Dec 16, 2025 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR removes the request to the feature-freeze webhooks, so the CfT P2 post is no longer published.
It has been decided that we no longer need that P2 post, see more context here: p1765545196896889/1764685825.879859-slack-C01DT6U03HC

Part of #62071

How to test the changes in this Pull Request:

The test is to make sure everything else in the workflow still works:

  1. Fork this repository, including the fix/62071-delete-cft-p2-post branch.
  2. Create a new PR for the fix/62071-delete-cft-p2-post and merge it to trunk.
  3. Create the Release label in your fork repo.
  4. Go to Settings > Secrets and variables > Actions in your repo and add the following secrets / values:
    Secret name Value
    RELEASE_CALENDAR_ID 46e4204b5406a5c6df48addc0dfd3a29e5e69ad7e991b165fa4e331f03ede0e0@group.calendar.google.com
    CODE_FREEZE_BOT_TOKEN Token from secret store item Test Assistant bot
    WOO_RELEASE_SLACK_CHANNEL test-woo-core-release-notifications
  5. Go to Actions > Release: Enforce Feature Freeze in your fork and run the workflow.
  6. Wait until it completes.
  7. Confirm that:
    • A PR bumping the version on trunk to 10.6.0-dev has been created in your fork.
    • Branch release/10.5 has been created in your fork.
    • Release 10.5.0-dev has been published in your fork.
    • Slack notification about the code freeze sent to #test-woo-core-release-notifications.

Testing that has already taken place:

Milestone

Note: Check the box above to have the milestone automatically assigned when merged.
Alternatively (e.g. for point releases), manually assign the appropriate milestone.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@github-actions github-actions bot added the focus: monorepo infrastructure Issues and PRs related to monorepo tooling. label Dec 16, 2025
@albarin albarin marked this pull request as ready for review December 16, 2025 14:54
@albarin albarin requested a review from a team as a code owner December 16, 2025 14:54
@albarin albarin requested review from Konamiman and removed request for a team December 16, 2025 14:54
@woocommercebot woocommercebot requested a review from a team December 16, 2025 14:55
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

Testing Guidelines

Hi @Konamiman @woocommerce/flux,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

A GitHub Actions workflow file has been simplified by removing the "Trigger Release Webhook" job and its associated steps, which previously computed payloads, signed requests, and sent webhook notifications. The notify-slack job dependency was updated accordingly.

Changes

Cohort / File(s) Change Summary
Release Workflow Simplification
\.github/workflows/release-code-freeze\.yml		 Removed the entire trigger-webhook job including payload computation, request signing, and webhook dispatch logic. Removed trigger-webhook from the notify-slack job dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the webhook functionality is no longer required downstream or in other workflows
  • Confirm that removing trigger-webhook from notify-slack dependencies doesn't introduce timing or ordering issues
  • Check if any external systems were relying on the webhook payloads being sent

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing the feature-freeze webhook request from the workflow.
Description check ✅ Passed The description is related to the changeset, providing context about why the webhook is being removed and testing instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/62071-delete-cft-p2-post
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3049f08 and 33fbf2d.

📒 Files selected for processing (1)
  • .github/workflows/release-code-freeze.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: prettyboymp
Repo: woocommerce/woocommerce PR: 59048
File: .github/workflows/cherry-pick-milestoned-prs.yml:118-131
Timestamp: 2025-07-11T13:05:08.440Z
Learning: In GitHub Actions workflows, when reviewing steps that access event data like `github.event.pull_request.milestone`, check the entire job dependency chain and conditional logic. If upstream jobs already validate the data exists (like checking `github.event.pull_request.milestone != null` in a prerequisite job), then downstream jobs don't need redundant null-checks since the data is guaranteed to exist by that point.

Learnt from: prettyboymp
Repo: woocommerce/woocommerce PR: 60272
File: .github/workflows/release-open-issue-warning.yml:15-23
Timestamp: 2025-08-08T13:52:26.423Z
Learning: Repository: woocommerce/woocommerce
Context: .github/workflows/release-open-issue-warning.yml and similar workflows
Learning: Maintainers (per prettyboymp) are fine requiring third-party modules inside actions/github-script without adding setup-node/createRequire. Prefer to keep this pattern and defer structural changes unless it demonstrably causes issues; minor safeguards like version pinning are acceptable if needed.
📚 Learning: 2025-08-08T13:52:26.423Z 
Learnt from: prettyboymp
Repo: woocommerce/woocommerce PR: 60272
File: .github/workflows/release-open-issue-warning.yml:15-23
Timestamp: 2025-08-08T13:52:26.423Z
Learning: Repository: woocommerce/woocommerce
Context: .github/workflows/release-open-issue-warning.yml and similar workflows
Learning: Maintainers (per prettyboymp) are fine requiring third-party modules inside actions/github-script without adding setup-node/createRequire. Prefer to keep this pattern and defer structural changes unless it demonstrably causes issues; minor safeguards like version pinning are acceptable if needed.

Applied to files:

  • .github/workflows/release-code-freeze.yml
🔇 Additional comments (1)
.github/workflows/release-code-freeze.yml (1)

326-326: Dependency list correctly updated. The removal of trigger-webhook from the needs array is necessary since that job was deleted. All remaining dependencies exist and are properly defined in the workflow.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@albarin albarin closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Konamiman Konamiman Awaiting requested review from Konamiman Konamiman is a code owner automatically assigned from woocommerce/flux

Assignees

No one assigned

Labels

focus: monorepo infrastructure Issues and PRs related to monorepo tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@albarin