Allow configuring page size and parallelism for conversation migration to PostgreSQL #4904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds configurable page size and parallelism parameters for the conversation migration from Cassandra to PostgreSQL. The migration previously used hardcoded values (pageSize: 10000), but now allows operators to tune these parameters based on their infrastructure capacity and migration requirements.
Key changes:
- Introduces
MigrationOptionsdata type withpageSizeandparallelismfields - Updates migration functions to accept and use configurable options
- Adds configuration settings in Helm charts and YAML config files
- Implements parallel processing using
unsafePooledMapConcurrentlyN_for improved migration performance
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/wire-subsystems/src/Wire/ConversationStore/Migration.hs | Adds MigrationOptions data type, updates migration functions to accept options, implements parallelism using unsafePooledMapConcurrentlyN_, and adds Concurrency 'Unsafe effect to the effect stack |
| services/background-worker/src/Wire/MigrateConversations.hs | Updates function calls to pass MigrationOptions (incomplete - uses underscore placeholders) |
| services/background-worker/src/Wire/BackgroundWorker/Options.hs | Adds migrateConversationsOptions field to Opts data type |
| services/background-worker/background-worker.integration.yaml | Adds default configuration values for migration options (pageSize: 10000, parallelism: 2) |
| charts/background-worker/values.yaml | Adds migration options configuration to Helm chart defaults |
| charts/background-worker/templates/configmap.yaml | Updates ConfigMap template to include migration options in generated configuration |
| changelog.d/2-features/faster-migration | Documents the new feature with configuration example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
battermann
requested changes
Dec 11, 2025
Comment on lines
42
to
43
| convLoop <- async . lift $ migrateConvsLoop _ cassClient pgPool logger convMigCounter convMigFinished convMigFailed | ||
| userLoop <- async . lift $ migrateUsersLoop _ cassClient pgPool logger userMigCounter userMigFinished userMigFailed |
Contributor
There was a problem hiding this comment.
typed hole can't be correct here
blackheaven
approved these changes
Dec 11, 2025
Comment on lines
-42
to
-43
| convLoop <- async . lift $ migrateConvsLoop cassClient pgPool logger convMigCounter convMigFinished convMigFailed | ||
| userLoop <- async . lift $ migrateUsersLoop cassClient pgPool logger userMigCounter userMigFinished userMigFailed |
Contributor
There was a problem hiding this comment.
does it compile with holes?
Member
Author
There was a problem hiding this comment.
No, why did you approve it 😅
1c4803d to
3c1d331
Compare
battermann
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d