Skip to content

Fixing button command early-bail steps #12021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jakearchibald wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixing button command early-bail steps #12021

jakearchibald wants to merge 2 commits into from
+40 −25

Conversation

@jakearchibald
Copy link
Collaborator

@jakearchibald jakearchibald commented Dec 16, 2025 •
edited by pr-preview bot
Loading

The previous spec seemed to allow all commands through if the element was a popover, whereas it was only intended to allow popover commands through.

Firefox and Safari follow the intent of the spec. Chrome kinda gets it wrong but wasn't following the previous wording of the spec either. I'll file a bug with them.

  • At least two implementers are interested (and none opposed):
    • Firefox
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • Corresponding HTML AAM & ARIA in HTML issues & PRs:
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/form-elements.html ( diff )

keithamus
keithamus approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM.

@lukewarlow
Copy link
Member

lukewarlow commented Dec 16, 2025

Good catch!

@mfreed7
Copy link
Collaborator

mfreed7 commented Dec 16, 2025

Thanks! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jakearchibald @lukewarlow @mfreed7 @keithamus