Skip to content

Make fetch() use "same-origin" credentials by default #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2018
Merged

Make fetch() use "same-origin" credentials by default #585

merged 1 commit into from
Apr 20, 2018
+1 −1

Conversation

annevk
Copy link
Member

@annevk annevk commented Aug 25, 2017 •
edited by pr-preview bot
Loading

Most features in the platform have this default and not having this default causes multiple connections in contemporary implementations. It also causes confusion as switching from XMLHttpRequest to fetch() is not as seamless as it could be.

Making this change will also make it easier for <script type=module> to have this default as per discussion in whatwg/html#2557.

Preview | Diff

@annevk
Make fetch() use "same-origin" credentials by default
5550bf9 
Most features in the platform have this default and not having this default causes multiple connections in contemporary implementations. It also causes confusion as switching from XMLHttpRequest to fetch() is not as seamless as it could be.

Making this change will also make it easier for <script type=module> to have this default as per discussion in whatwg/html#2557.
@annevk
Copy link
Member Author

annevk commented Aug 25, 2017

cc @youennf @wanderview @tyoshino @domenic @mikewest @jakearchibald @yutakahirano

@annevk annevk mentioned this pull request Aug 25, 2017
Closed
@Munter
Copy link

Munter commented Aug 25, 2017 •
edited
Loading

Even though I have followed the fetch spec development and implementation and have read multiple blog posts on how to use it, I still got tripped up by forgetting to manually add credentials on certain same-origin fetch-calls. +1 from me on this change

@tyoshino
Copy link
Member

I agree that this is a more reasonable default, but also much concerned with possible break of existing apps, though your guess at whatwg/html#2557 (comment) sounds correct.

Let me cc interop leads: @RByers @foolip

@jakearchibald