Skip to content

Conversation

@seanjohnson08
Copy link

Problem:
On certain linux distros (tested on RedHat Enterprise) an older version of Py GTK is installed by default. This commit adds support for older versions of PyGTK (specifically 2 instead of the newer version 3).

Solution:
Provide backwards compatibility for GTK2, without hurting support for GTK3.

Testing:
Tested that the color picker:

  • opens
  • is cancelable/closeable
  • color chosen is passed back to sublime
  • if the user had previously selected a color in sublime, the color picker is pre-filled with that color
    ... in GTK 2 environment.

Also tested for GTK3, which was already supported.

Fixes #65

weslly added a commit that referenced this pull request Apr 11, 2015
Added support for more Linux Distros
@weslly weslly merged commit fac4528 into weslly:master Apr 11, 2015
@weslly
Copy link
Owner

weslly commented Apr 11, 2015

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

installation not working

2 participants