Fix showing card activity history in IE11 #646
Conversation
IE11 seems to have issues with combining the animationend listener with the .card-details selector, so we work around it by also setting a timeout matching the animation time in case we're on IE and the animationend event never fires.
|
|
|
Thank you, that actually looks reasonable to me. The deffer-ed display has less to do with the actual animation than with Blaze slowdown on large list rendering, so having a timeout to say that the feed should be displayed after 100ms whatever happened isn’t that bad. |
|
Thanks for the hint to use Microsoft VMs, I was able to find the root cause of the bug, which is now fixed. |
|
bda1df5 does not seem to fix the issue for me on IE11. |
|
To be more precise: after wefork@6090ede, the comments immediately show up on the versions of Edge, Chrome, and Firefox that I've tested. On IE11, I still need to wave my mouse over the card before the comments show up (but I guess that's better than the comments never showing up at all). |
Support for IE11 wekan#646
Fix showing card activity history in IE11. Thanks to nztqa ! Closes #646
The animationend event doesn't seem to fire the way we expect it to under IE11. This means that card history will never be visible when looking at card details in IE11, so work around it by also setting a timeout matching the animation time in case the animationend event never fires.
If you know of a better way to deal with this, I'm happy to adjust this patchset. :)
Tested in IE11 on Win7 via the modern.ie VMs: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/
This change is