Fix #5732 list insert position #5766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nourguidara |
|
I believe I’m experiencing the same issue, and I’ll be creating a PR to fix these problems. Instead of replacing the use of ReactiveCache, I’ll ensure that all selections properly leverage it for consistency and reactivity. |
|
Moved to #5767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces and improves on #5765 and still addresses #5732
It fixes two issues:
-Previously, lists added using "Add After" were inserted at the end instead of right after the selected list.
-A runtime error occurred when the .list-position-input
I have tested this manually:
-Adding a list "after" another works and respects list order
-The browser console shows no JavaScript errors