Skip to content

Conversation

Jack-Works
Copy link
Contributor

  • fix: deferred modules define order in concatenated modules
  • fix: transitive deferred module not emitted correctly in concatenated modules

What kind of change does this PR introduce? fix: defer module in concatenated modules

Did you add tests for your changes? yes

Does this PR introduce a breaking change? no

What needs to be documented once your changes are merged? no

Copy link

codspeed-hq bot commented Sep 12, 2025

CodSpeed Performance Report

Merging #19902 will degrade performances by 37.8%

Comparing Jack-Works:fix-defer (b93c085) with main (16c6966)

Summary

⚡ 2 improvements
❌ 1 regression
✅ 39 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "devtool-eval", scenario '{"name":"mode-development","mode":"development"}' 317.1 ms 239.6 ms +32.33%
benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 44.7 ms 71.8 ms -37.8%
benchmark "react", scenario '{"name":"mode-development","mode":"development"}' 251.6 ms 193.1 ms +30.28%

@alexander-akait
Copy link
Member

Let's filter test with globalThis, node10 is not supported using test.filter.js, ignore node v24, looks like the new release is break something in vm, we are working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants