Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Conversation

@marccarre
Copy link
Contributor

@marccarre marccarre commented Dec 13, 2016

@brb brb added this to the 1.9.0 milestone Dec 13, 2016
@marccarre marccarre force-pushed the 2647-testing-mvp branch 19 times, most recently from 56bb754 to 267f504 Compare December 19, 2016 17:20
@marccarre marccarre self-assigned this Dec 21, 2016
@marccarre marccarre force-pushed the 2647-testing-mvp branch 7 times, most recently from 309a839 to d1e8670 Compare January 4, 2017 19:02
Provisioning and configuration being expensive time-wise, we create Google Cloud Platform images for each Docker/Kubernetes/Kubernetes CNI versions triple, and configure these once (instead of for each build), and then re-use these in subsequent builds, effectively implementing a 'cache' of images.
This way, Vagrant VMs and cloud-provided VMs are configured in the exact same way, hence avoiding configuration drift and subtle bugs associated to different versions of software.
This should help speed-up the build by provisioning test VMs while we run unit tests, and destroying them while we generate coverage reports.
There may be situations when Terraform/Ansible/etc. fail to provision test machines.
In these cases, we want to fail fast instead of waiting until we time out in circle-test-pre and circle-test-smoke.
Doing so in circle-dependencies-post arrives too late for background provisioning.
CircleCI keeps 10 nodes in order to speed up the build, but the default is 3, as this is the minimum required to run any test. This should make more sense as a default for a developer to quickly start an environment and iterate.
This should speed the build up, and provide faster feedback to developers.
…S=...".

This should make development easier by allowing developers to set HOSTS in their calling shell, and re-use the value for this env. var. when calling individual test scripts, e.g.:
```
cd test
eval $(./run-integration-tests.sh setup)
./200_dns_test.sh
```
This should be useful when we just want to type one make integration-tests / ./run-integration-tests command to make/start VMs/configure them/test, but also investigate potential failures afterwards.
…rent directory.

Sourcing failed when running make integration-tests.
We previously had 'use image' as a default, but not 'create image', which is inconsistent and leads to unexpected failures.
@marccarre marccarre changed the base branch from master to 1.9 February 8, 2017 14:16
@marccarre
Copy link
Contributor Author

@brb, as discussed:

  • rebased onto 1.9
  • PR's base branch updated to be 1.9
  • upgraded to latest version of build-tools's master branch.

@marccarre marccarre requested a review from brb February 8, 2017 14:18
@marccarre marccarre assigned brb and unassigned marccarre and bboreham Feb 8, 2017
PATH: $PATH:$HOME/.local/bin
CLOUDSDK_CORE_DISABLE_PROMPTS: 1
STATE: /home/ubuntu/state.env
NUM_HOSTS: 16

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@brb brb merged commit dff5b6d into 1.9 Feb 8, 2017
@marccarre marccarre deleted the 2647-testing-mvp branch February 8, 2017 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants