This repository was archived by the owner on Jun 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 680
Testing MVP #2694
Merged
Merged
Testing MVP #2694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56bb754 to
267f504
Compare
267f504 to
c9e85af
Compare
c9e85af to
606f811
Compare
309a839 to
d1e8670
Compare
Provisioning and configuration being expensive time-wise, we create Google Cloud Platform images for each Docker/Kubernetes/Kubernetes CNI versions triple, and configure these once (instead of for each build), and then re-use these in subsequent builds, effectively implementing a 'cache' of images.
This way, Vagrant VMs and cloud-provided VMs are configured in the exact same way, hence avoiding configuration drift and subtle bugs associated to different versions of software.
This should help speed-up the build by provisioning test VMs while we run unit tests, and destroying them while we generate coverage reports.
There may be situations when Terraform/Ansible/etc. fail to provision test machines. In these cases, we want to fail fast instead of waiting until we time out in circle-test-pre and circle-test-smoke.
Doing so in circle-dependencies-post arrives too late for background provisioning.
CircleCI keeps 10 nodes in order to speed up the build, but the default is 3, as this is the minimum required to run any test. This should make more sense as a default for a developer to quickly start an environment and iterate.
This should speed the build up, and provide faster feedback to developers.
…S=...". This should make development easier by allowing developers to set HOSTS in their calling shell, and re-use the value for this env. var. when calling individual test scripts, e.g.: ``` cd test eval $(./run-integration-tests.sh setup) ./200_dns_test.sh ```
This should be useful when we just want to type one make integration-tests / ./run-integration-tests command to make/start VMs/configure them/test, but also investigate potential failures afterwards.
…rent directory. Sourcing failed when running make integration-tests.
We previously had 'use image' as a default, but not 'create image', which is inconsistent and leads to unexpected failures.
385eb1f to
c026579
Compare
Contributor
Author
|
@brb, as discussed:
|
brb
reviewed
Feb 8, 2017
| PATH: $PATH:$HOME/.local/bin | ||
| CLOUDSDK_CORE_DISABLE_PROMPTS: 1 | ||
| STATE: /home/ubuntu/state.env | ||
| NUM_HOSTS: 16 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
brb
approved these changes
Feb 8, 2017
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2664.
Fixes #2676.
Fixes #2682.
See also: