This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Persist IPAM ring, take 2 #1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It seems odd that the key is supplied as a []byte rather than a string. |
Contributor
Perhaps this is some artefact of the implementation (mmap'ed B+Tree) that is leaking out for efficiency purposes? |
c06b809 to
fea03bf
Compare
Contributor
D'oh I thought you were talking about the BoltDB API 😄 |
…ed on a restart. Create `Allocator.fatalf()`, for consistency
a19fbaf to
546f959
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised version of #1928, with BoltDB specifics pulled out to a separate package.
We have a very simple persistence interface, just
LoadandSaveaninterface{}, with serialization (Gob) hidden behind the abstraction.Partial fix of #678