This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Support requesting a specific IP from the plugin #1916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90cf117 to
c72727b
Compare
Contributor
Author
|
Rebased |
plugin/ipam/driver.go
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
c72727b to
02a3e30
Compare
Contributor
Author
|
I clarified the intended meaning, and removed the word "preferred" from Docker's code. But there is a new problem: requesting the same address twice does not fail. Currently we can't easily do a smoke-test because the |
02a3e30 to
610a90c
Compare
Contributor
Author
|
Fixed the problem that requesting the same address twice did not fail. |
awh
added a commit
that referenced
this pull request
Jan 29, 2016
Support requesting a specific IP from the plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1734