memory correctness #374
Merged
memory correctness #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize all boolean member variables to false in the Parameters struct to prevent undefined behavior when the copy constructor is invoked. UBSan previously reported: runtime error: load of value 16, which is not a valid value for type 'bool' This fix ensures all boolean fields have defined values on construction.
Added wrapper structs with destructors to properly clean up thread-local faidx_reader_t objects in computeMap.hpp and map_stats.hpp. Previously, thread-local readers were never destroyed, causing memory leaks reported by AddressSanitizer (~4MB per run in test case). The fix uses RAII pattern: - computeMap.hpp: ReaderWrapper struct for single thread-local reader - map_stats.hpp: ReaderMapWrapper struct for map of readers per file This ensures readers are properly destroyed when threads terminate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure everything is correctly initialized and destroyed.