[Cryptography] Optimize hash functionality #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
wangkanai
commented
Jul 23, 2023
- Adler32 if more than 4096, how to split into chuck.
- [ ] Adler32 if more than 4096, how to split into chuck.
[System] add string extensions unit tests
[System] fixed the failed whitespace unit test
wangkanai
commented
Aug 9, 2023
Cryptography/src/Adler32.cs
Outdated
| public static int Checksum(string text) | ||
| => Checksum(Encoding.ASCII.GetBytes(text)); | ||
| { | ||
| return Checksum(Encoding.ASCII.GetBytes(text)); |
Owner
Author
There was a problem hiding this comment.
Should check if length greater than 4096 before converting to byte[]?
Owner
Author
There was a problem hiding this comment.
Need to check the performance difference and make a decision
Owner
Author
There was a problem hiding this comment.
There is not much difference between checking for exceptions before or after converting to bytes.
|
信已收到
|
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.