Skip to content

Change aria-errormessage to ID reference list #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

Change aria-errormessage to ID reference list #1802

merged 1 commit into from
Jan 11, 2023

Conversation

mrego
Copy link
Member

@mrego mrego commented Sep 15, 2022 •
edited by pr-preview bot
Loading

Fixes #1730.

Changes aria-errormessage to be an ID reference list

PR tracking

  • Related Core AAM PR:
  • Related AccName PR:
  • Related APG PR:
  • Any other dependent changes?

Implementation tracking

  • validator tests
  • WPT tests: LINK
  • Browser implementations (link to issue or when done, link to commit):
    • WebKit: Implemented
    • Gecko: Implemented
    • Blink: ISSUE
  • Does this need AT implementations?

Preview | Diff

@mrego mrego mentioned this pull request Sep 15, 2022
Closed
@cyns
Copy link
Contributor

cyns commented Sep 16, 2022

In Core-AAM it already has multiple references for IA2 and ATK/ATSPI.
Windows UI uses ControllerFor, which takes an array of references, so that can work

AX API (Mac) uses a text property and may not be able to support this.
@cookiecrook can this get text from multiple elements? Property: AXValidationError: textual content of the referenced element

@cyns cyns requested review from cyns and cookiecrook September 16, 2022 22:34
@cyns cyns mentioned this pull request Sep 16, 2022
Closed
cyns
cyns approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cyns cyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also w3c/core-aam#138 to make core-aam align with this change

@jnurthen
Copy link
Member

@jcsteh can you please take a look at this.

@cookiecrook
Copy link
Contributor

cookiecrook commented Sep 29, 2022 •
edited
Loading

AX API (Mac) uses a text property and may not be able to support this. @cookiecrook can this get text from multiple elements? Property: AXValidationError: textual content of the referenced element

Yes, WebKit could concatenate the text equivalents into the string for the API, or the API owners could consider a change.

@mrego