Skip to content

Fix for "name required" for tab at 5.2.8.4 and 5.2.8.5 #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

Fix for "name required" for tab at 5.2.8.4 and 5.2.8.5 #1771

merged 1 commit into from
Jul 22, 2022

Conversation

SalazarJosh
Copy link
Contributor

@SalazarJosh SalazarJosh commented Jul 20, 2022 •
edited by pr-preview bot
Loading

Addresses 1768

(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True " instead of "True".

Preview | Diff

@SalazarJosh
Fix for "name required" for tab at 5.2.8.4 and 5.2.8.5
bda2db6 
(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True " instead of "True".
scottaohara
scottaohara approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does the trick. thanks

@spectranaut
Copy link
Contributor

@pkra I think we can merge this?

@pkra
Copy link
Member

pkra commented Jul 22, 2022 •
edited
Loading

@pkra I think we can merge this?

@spectranaut Is it ok for me to resolve the ipr failure as "non-substantial"?

@w3cbot
Copy link

w3cbot commented Jul 22, 2022

pkra marked as non substantive for IPR from ash-nazg.

@pkra
Copy link
Member

pkra commented Jul 22, 2022 •
edited
Loading

I think this falls clearly in the "typos" category mentioned on the ipr page.

@pkra pkra merged commit 7a56f40 into w3c:main Jul 22, 2022
github-actions bot added a commit that referenced this pull request Jul 22, 2022
@SalazarJosh @github-actions
Fix for "name required" for tab at 5.2.8.4 and 5.2.8.5 (#1771)
2462f44 
SHA: 7a56f40
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pkra pushed a commit that referenced this pull request Jul 22, 2022
@SalazarJosh @pkra
Fix for "name required" for tab at 5.2.8.4 and 5.2.8.5 (#1771)
2b2db91 
(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True&nbsp;" instead of "True".
@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Jul 22, 2022
@pkra pkra added this to the ARIA 1.3 milestone Jul 22, 2022
@scottaohara scottaohara mentioned this pull request Jul 25, 2022
Closed
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@SalazarJosh @jnurthen
Fix for "name required" for tab at 5.2.8.4 and 5.2.8.5 (#1771)
602c5e3 
(name required) is missing for "tab" on 5.2.8.4 and 5.2.8.5. The query is searching the "Accessible Name Required:" value to be "True". There were extra spaces around that value so the string read "True&nbsp;" instead of "True".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara approved these changes

Assignees

@pkra pkra

Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.
5 participants
@SalazarJosh @spectranaut @pkra @w3cbot @scottaohara