Skip to content

T028: Heatmap with similarity matrix #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

T028: Heatmap with similarity matrix #236

merged 1 commit into from
Jun 3, 2022

Conversation

t-kimber
Copy link
Contributor

@t-kimber t-kimber commented Jun 2, 2022 •
edited
Loading

Description

To avoid any confusion:

  • heatmaps are calculated using the similarity matrix
  • dendrograms are computed using the distance matrix

Status

  • Ready to go

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@t-kimber t-kimber self-assigned this Jun 2, 2022
@t-kimber t-kimber requested a review from dominiquesydow June 2, 2022 10:53
@dominiquesydow dominiquesydow changed the base branch from master to livecoms-review June 3, 2022 08:09
dominiquesydow
dominiquesydow approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@dominiquesydow dominiquesydow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! This is ready to go from my side as well. Merging into our livecoms-review base branch.

@dominiquesydow dominiquesydow merged commit 6259f90 into livecoms-review Jun 3, 2022
@dominiquesydow dominiquesydow mentioned this pull request Jun 3, 2022
Merged
9 tasks
@dominiquesydow dominiquesydow deleted the T028-heatmap branch June 3, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominiquesydow dominiquesydow dominiquesydow approved these changes

Assignees

@t-kimber t-kimber

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-kimber @dominiquesydow