Support for globbing in the input path of the Hadoop Store Builder #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the HadoopStoreBuilder only has partial support for file path globbing.
If you use a glob in the
--inputargument eg.--input data/store_a/part-r-*the store will build but the data size will be counted as 0 thus the number of chunk (num.chunks) will be set to 1. If the store that you are generating is large then the generation will fail with aVoldemortException:This patch adds file path globbing support to the
HadoopStoreBuilder.sizeOfPathmethod so that the input size can be correctly determined and the correct number of chunks calculated.