Cherry-pick: VicVmViewService refine and fix: folder can not show clusters in create vch vizard. #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will introduce a new logic into the resource tree selector component in order to allow users to be able to select Clusters within folders and also non-vic ResourcePools
…e#579) This will add a missing service provider VicVmViewService that should be added to the root app Module in order to fix VIC summary view plugin.
f0fa11b to
bf71b38
Compare
renmaosheng
approved these changes
Aug 30, 2018
Member
|
Cherry-picks should be performed with |
Member
|
What testing has been performed for this change? We typically document this in the pull request's description for easy reference by reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick:
1 Fix missed service provider VicVmViewService in the app module
2 Resource tree selector refactor (#561)
This change will introduce a new logic into the resource tree selector component in order to allow users to be able to select Clusters within folders and also non-vic ResourcePools