Skip to content

fix(expect): allow function as standard schema #9099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 2 commits into from
Nov 25, 2025
Merged

fix(expect): allow function as standard schema #9099

sheremet-va merged 2 commits into from
Nov 25, 2025
+6 −1

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 25, 2025 •
edited
Loading

Description

Resolves #9098

The effect repro is confirmed to be fixed https://stackblitz.com/edit/vitest-dev-vitest-v8w4aeqc?file=test%2Fbasic.test.ts

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Nov 25, 2025

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a746b4d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69254cbec5c8e50008c85dc1
😎 Deploy Preview https://deploy-preview-9099--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 25, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@9099

@vitest/browser-playwright

npm i https://pkg.pr.new/@vitest/browser-playwright@9099

@vitest/browser-preview

npm i https://pkg.pr.new/@vitest/browser-preview@9099

@vitest/browser-webdriverio

npm i https://pkg.pr.new/@vitest/browser-webdriverio@9099

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@9099

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@9099

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@9099

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@9099

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@9099

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@9099

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@9099

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@9099

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@9099

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@9099

vitest

npm i https://pkg.pr.new/vitest@9099

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@9099

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@9099

commit: a746b4d

@hi-ogawa hi-ogawa marked this pull request as ready for review November 25, 2025 06:56
@sheremet-va sheremet-va merged commit ed8a2eb into vitest-dev:main Nov 25, 2025
15 of 18 checks passed
@hi-ogawa hi-ogawa deleted the 11-25-fix_expect_allow_function_as_standard_schema branch November 25, 2025 10:03
@claude claude bot mentioned this pull request Nov 25, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

cr-tracked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Standard Schema matcher incompatible with Effect

2 participants

@hi-ogawa @sheremet-va